Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fanar.model/http.method/http.urland ranInterceptorChainImplin its own privatedispatch. That lives in oneqa.fanar.core.internal.dispatch.Dispatchernow (0.4.0 plan, Phase 6); each facade'sdispatchis a one-line delegation and the class owns only its endpoint, wire format and decoding. Net −104 lines.FanarClientand all eight*ClientImplTests are untouched (each facade builds its ownDispatcherfrom the same arguments).http.urlis now read from the request the facade built rather than its endpoint field — always the same URI, including the per-name voice delete.internal.transport:RetryInterceptoralready imports frominternal.transport, so placing it there would have made retry ↔ transport cyclic.DispatcherTestproves attribute order, the omitted model attribute, chain order (a user interceptor sees the bearer header the built-in set) and null arguments; ARCHITECTURE, PROJECT_STATE and CHANGELOG updated.Type of change
Test plan
mvn verifypasses locallyFANAR_API_KEYset)--self-testpasses (if the SDK's reflective surface changed)Reviewer checklist
*IntegrationTestproves the behaviour this PR claims? (100 % JaCoCo on a unit is not proof of wiring — see CONTRIBUTING "Testing")@Deprecated(since, forRemoval = true)and a migration path in the PR descriptionqa.fanar.corepublic APImemory/so future contributors find it